Code gems on PsiloMan

Did you say: factorisation?

Fri, 24 Apr 2015 20:49:00 +0200

I think he must have been paid by the line of code.

OR (
UPPER('".remove_everything_but_letter_plus($agent_firstname)."') LIKE '%.%'
OR UPPER('".remove_everything_but_letter_plus($agent_firstname)."') LIKE '% %'
OR UPPER('".remove_everything_but_letter_plus($agent_firstname)."') LIKE '%-%'
OR UPPER('".remove_everything_but_letter_plus($agent_firstname)."') LIKE '%''%'
OR UPPER('".remove_everything_but_letter_plus($agent_lastname)."') LIKE '%.%'
OR UPPER('".remove_everything_but_letter_plus($agent_lastname)."') LIKE '% %'
OR UPPER('".remove_everything_but_letter_plus($agent_lastname)."') LIKE '%-%'
OR UPPER('".remove_everything_but_letter_plus($agent_lastname)."') LIKE '%''%' )

Code of the function remove_everything_but_letter_plus:

function remove_everything_but_letter_plus($string)
{
	$string = preg_replace('/[^A-Za-z \'\.\-]/', '', $string);
	$string = sql_escape($string);
	return $string;
}

I TRIM, you TRIM, he TRIMs

Fri, 24 Apr 2015 20:49:00 +0200

You never know whether the first one did not work. A TRIM forewarned is worth two.

if (isset($_GET['id_coll'])) $id_coll = trim($_GET['id_coll']);
else $id_coll = '';

if (trim($id_coll)!='' && is_numeric($id_coll))
{
 ......
}

A pointless test

Mon, 04 Feb 2013 15:00:00 +0100

After retrieving one character from the string held in the array, he tests whether the result could be equal to a word.

$user_regime = trim(strtoupper(remove_everything_but_letter_space(substr($tabinfouser[17], 0, 1))));
if ($user_regime == 'ALPHA') $user_regime = 'A';
else if ($user_regime == 'BETA') $user_regime = 'B';
else if ($user_regime == 'OMEGA') $user_regime = 'O';
else if ($user_regime == 'EPSILON') $user_regime = 'E';

Code of the function remove_everything_but_letter_space:

function remove_everything_but_letter_space($string)
{
	$string = preg_replace('/[^A-Za-z \-]/', '', $string);
	return $string;
}

Concatenation is optimisation

Sun, 03 Feb 2013 15:15:00 +0100

$content = str_replace('{#(Pr@uT[};MR;', "\r\n".';MR;', $content);
$content = str_replace('{#(Pr@uT[};MME;', "\r\n".';MME;', $content);
$content = str_replace('{#(Pr@uT[};MLLE;', "\r\n".';MLLE;', $content)

Concatenating “\r\n” with ‘;MR;’ optimises the execution of the PHP script. I would have written:

$content = str_replace('{#(Pr@uT[};MR;', "\r\n;MR;", $content);
$content = str_replace('{#(Pr@uT[};MME;', "\r\n;MME;", $content);
$content = str_replace('{#(Pr@uT[};MLLE;', "\r\n;MLLE;", $content)

But I am only self-taught.

A user confirmation that will never be displayed

Sat, 02 Feb 2013 17:00:00 +0100

After reading the code, I asked him whether he had tested it. The answer was, of course, yes. My answer was that I think there is a small bug around line 67 of his script.

function confirmation() {
	if (trim(document.getElementById('ANIMATION').value) == '' ) {
		alert('Merci de remplir les champs du formulaire avant validation');
		return false;
	} else {
		return true;
	}

	var answer = confirm('En cliquant sur le bouton "Valider définitivement" les informations que vous avez saisie, cliquez sur OK, sinon, cliquez sur Annuler');
	if (answer) {
		return true;
	} else {
		return false;
	}
}

A somewhat greedy script

Fri, 01 Feb 2013 14:30:00 +0100

15 minutes of execution with 2 GB of memory.

set_time_limit(900);
ini_set('memory_limit','2048M');
error_reporting(E_ALL);

A condition that is always true

Thu, 31 Jan 2013 15:00:00 +0100

This little gem was written by someone who says they studied at the best computer-science IUT (a French university institute of technology), in Orsay. I think he must have missed some classes.

if (1) {
 // 400 lines of code
 ...
}

if (isset($details_csv)) return $details_csv;
else return '';